Skip to content

Add session cookie support to WebSocket handshakes#697

Merged
ryanfowler merged 1 commit into
mainfrom
fix-websocket-session-cookies
Jun 2, 2026
Merged

Add session cookie support to WebSocket handshakes#697
ryanfowler merged 1 commit into
mainfrom
fix-websocket-session-cookies

Conversation

@ryanfowler

Copy link
Copy Markdown
Owner

Summary

  • Load named sessions for ws:// and wss:// requests, attach matching cookies to the upgrade request, and persist Set-Cookie headers from successful handshake responses.
  • Reuse the existing HTTP session store by translating WebSocket URLs to their HTTP equivalents for cookie matching.
  • Add an integration test covering HTTP login, WebSocket upgrade cookie transmission, and handshake cookie persistence.
  • Update the repo notes to document the new WebSocket session behavior.

Testing

  • cargo fmt
  • cargo clippy --locked --all-targets --all-features -- -D warnings
  • cargo test --all-features --test websocket -- --test-threads=1
  • cargo test --all-features

@ryanfowler ryanfowler merged commit 284c304 into main Jun 2, 2026
4 checks passed
@ryanfowler ryanfowler deleted the fix-websocket-session-cookies branch June 2, 2026 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant