Skip to content

Cap gRPC reflection response buffering#698

Merged
ryanfowler merged 1 commit into
mainfrom
cap-grpc-reflection-buffering
Jun 2, 2026
Merged

Cap gRPC reflection response buffering#698
ryanfowler merged 1 commit into
mainfrom
cap-grpc-reflection-buffering

Conversation

@ryanfowler

Copy link
Copy Markdown
Owner

Summary

  • Added reflection-specific limits to framed gRPC body collection so discovery responses cannot grow without bound from many small valid frames.
  • Applied a 128-message and 64 MiB decoded-byte cap to gRPC reflection reads, with clear errors when either limit is exceeded.
  • Added regression coverage for the hostile reflection case that overflows the message-count limit.

Testing

  • cargo fmt
  • cargo clippy --locked --all-targets --all-features -- -D warnings
  • cargo test --all-features grpc::body::tests
  • cargo test --all-features --test grpc grpc_reflection_rejects_too_many_framed_messages -- --test-threads=1

@ryanfowler ryanfowler enabled auto-merge June 2, 2026 15:55
@ryanfowler ryanfowler merged commit 43ee0dc into main Jun 2, 2026
4 checks passed
@ryanfowler ryanfowler deleted the cap-grpc-reflection-buffering branch June 2, 2026 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant