Skip to content

Abort HTTP/3 upload tasks on drop#700

Merged
ryanfowler merged 1 commit into
mainfrom
review-codebase
Jun 2, 2026
Merged

Abort HTTP/3 upload tasks on drop#700
ryanfowler merged 1 commit into
mainfrom
review-codebase

Conversation

@ryanfowler

Copy link
Copy Markdown
Owner

Summary

  • Wrap HTTP/3 upload tasks in an abort-on-drop guard as soon as they are spawned.
  • Preserve the finished-task fast path while ensuring in-flight uploads do not outlive request cancellation or response errors.
  • Add a regression test covering drop behavior for the upload task wrapper.

Testing

  • Added a unit test for H3UploadTask drop behavior.
  • Formatting and linting were run on the implementation path; targeted validation passed.

@ryanfowler ryanfowler enabled auto-merge June 2, 2026 19:57
@ryanfowler ryanfowler merged commit c7050ed into main Jun 2, 2026
4 checks passed
@ryanfowler ryanfowler deleted the review-codebase branch June 2, 2026 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant