Skip to content

Fix proxy-aware DNS pre-resolution for env proxies#703

Merged
ryanfowler merged 1 commit into
mainfrom
fix-proxy-dns-preresolution
Jun 2, 2026
Merged

Fix proxy-aware DNS pre-resolution for env proxies#703
ryanfowler merged 1 commit into
mainfrom
fix-proxy-dns-preresolution

Conversation

@ryanfowler

Copy link
Copy Markdown
Owner

Summary

  • Compute the effective explicit, environment, or system proxy before target DNS pre-resolution.
  • Skip local DNS lookups when the selected proxy resolves the target remotely, and keep local resolution only for plain socks5://.
  • Reuse the same proxy decision for redirect refresh handling and add a regression test for HTTPS_PROXY with --dns-server and -vvv.

Testing

  • cargo fmt
  • cargo clippy --locked --all-targets --all-features -- -D warnings
  • cargo test --all-features --test network env_https_proxy_skips_local_target_dns_preresolution
  • cargo test --all-features --test network
  • cargo test --all-features

@ryanfowler ryanfowler force-pushed the fix-proxy-dns-preresolution branch from 4707220 to 2205243 Compare June 2, 2026 23:06
@ryanfowler ryanfowler merged commit 6c848e2 into main Jun 2, 2026
4 checks passed
@ryanfowler ryanfowler deleted the fix-proxy-dns-preresolution branch June 2, 2026 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant