Skip to content

Bound SSE formatted stream buffer growth#707

Merged
ryanfowler merged 1 commit into
mainfrom
limit-sse-buffer-growth
Jun 3, 2026
Merged

Bound SSE formatted stream buffer growth#707
ryanfowler merged 1 commit into
mainfrom
limit-sse-buffer-growth

Conversation

@ryanfowler

Copy link
Copy Markdown
Owner

Summary

  • Add bounded pending-buffer handling to the SSE formatter so unterminated lines and events cannot grow without limit
  • Thread the new fallible SSE formatter API through the HTTP streaming path and reuse the existing response buffer ceiling
  • Add unit coverage for oversized pending input and for counter reset after event dispatch

Testing

  • cargo test --all-features
  • cargo test --all-features --test cli --test formatting --test grpc --test http --test network --test terminal --test update --test websocket -- --test-threads=1

@ryanfowler ryanfowler enabled auto-merge June 3, 2026 10:53
@ryanfowler ryanfowler merged commit 9c1d0cb into main Jun 3, 2026
4 checks passed
@ryanfowler ryanfowler deleted the limit-sse-buffer-growth branch June 3, 2026 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant