Skip to content

Deduplicate output install pipeline#726

Merged
ryanfowler merged 1 commit into
mainfrom
deduplicate-output-install-pipeline
Jun 7, 2026
Merged

Deduplicate output install pipeline#726
ryanfowler merged 1 commit into
mainfrom
deduplicate-output-install-pipeline

Conversation

@ryanfowler

Copy link
Copy Markdown
Owner

Summary

  • Extracted shared DownloadTemp setup and install/commit logic in src/output/mod.rs
  • Kept sync and async writers different only in how bytes are copied into the temp file
  • Added regression tests covering target-race handling for both sync and async output writes

Testing

  • cargo fmt
  • cargo clippy --locked --all-targets --all-features -- -D warnings
  • cargo test --all-features
  • cargo test --all-features --test cli --test formatting --test grpc --test http --test network --test terminal --test update --test websocket -- --test-threads=1

@ryanfowler ryanfowler enabled auto-merge June 7, 2026 23:40
@ryanfowler ryanfowler merged commit 18f323f into main Jun 7, 2026
4 checks passed
@ryanfowler ryanfowler deleted the deduplicate-output-install-pipeline branch June 7, 2026 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant