Fix from-curl proto schemeless URL handling#770
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix
--from-curl --protohandling for schemeless URLs that contain://later in the path, query, or fragment.The previous check used a loose
split_once("://"), which could mistake text after the authority position for an explicit URL scheme. This meant a command such ascurl --proto '=http' example.com/path://stillcould bypass the intended schemeless defaulting path and later normalize as HTTPS.This change reuses the HTTP URL authority-scheme detector so
--from-curl --protoonly treats a URL as explicitly schemed when the scheme appears before/,?, or#and is followed by//. Regression coverage now covers://in the path, query, and fragment.Validation
cargo fmtcargo fmt --checkcargo clippy --locked --all-targets --all-features -- -D warningscargo test --locked --all-features --lib --binscargo test --locked --all-features from_curl_protocargo test --locked --all-features authority_scheme_detection_requires_valid_leading_scheme