centralize color_for_status in core.rs#816
Merged
Merged
Conversation
Removes two duplicate definitions of color_for_status from src/http/metadata.rs and src/websocket/mod.rs, replacing them with a single pub fn in src/core.rs. Adds a pub(crate) re-export in src/http/mod.rs so that existing call sites in src/http/response/metadata.rs and src/http/retry.rs continue to work via use super::*.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes two duplicate definitions of
color_for_statusfromsrc/http/metadata.rsandsrc/websocket/mod.rs, replacing them with a singlepub fninsrc/core.rs. Adds apub(crate)re-export insrc/http/mod.rsso that existing call sites insrc/http/response/metadata.rsandsrc/http/retry.rscontinue to work viause super::*.