fix: include config file path in missing config error#821
Merged
Conversation
Previously, --config /nonexistent/path produced a bare OS error with no context. Now the error shows which config file was missing.
ryanfowler
force-pushed
the
fix-config-file-error-context
branch
from
d607ee2 to
d555985
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
--config /nonexistent/pathwas specified, the error was a bare OS error with no file context:Now the error includes which config file was not found, matching the pattern used by other file-path errors like
--proto-file:Validation: The change is a 1-line addition in
get_config_file— wraps thestd::fs::read_to_stringerror with aFetchError::Messageincluding the file path.