fix: make --connect-timeout/--retry-delay error messages consistent with clap style#823
Merged
Merged
Conversation
…ith clap style Error messages for negative --connect-timeout and --retry-delay values now use the same format as other clap-validated flags: invalid value '-5' for option '--connect-timeout': must be a non-negative number Previously they omitted the -- prefix and the reported value: connect-timeout must be a non-negative number
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Negative values for
--connect-timeoutand--retry-delaybypass clap validation (due toallow_hyphen_values) and produced inconsistent error messages:Now they match the clap-consistent pattern:
The new format is automatically parsed into a
FetchError::InvalidValuebyparse_invalid_value_errorinerror.rs, giving it proper ANSI styling (yellow value, bold flag).Validation:
cargo test --locked --all-features --lib --bins— all 830 tests pass.