Skip to content

fix: bound external image adapter execution#882

Merged
ryanfowler merged 2 commits into
mainfrom
fix/external-image-adapter-timeout
Jul 18, 2026
Merged

fix: bound external image adapter execution#882
ryanfowler merged 2 commits into
mainfrom
fix/external-image-adapter-timeout

Conversation

@ryanfowler

Copy link
Copy Markdown
Owner

Summary

  • apply one deadline to adapter execution and stdout collection
  • stop and terminate adapters immediately when stdout exceeds the cap
  • contain Windows adapters in a kill-on-close Job Object before execution begins
  • add regressions for inherited stdout and capped output

Validation

  • cargo fmt --check
  • cargo clippy --locked --all-targets --all-features -- -D warnings
  • cargo test --locked --all-features --lib --bins
  • focused external image adapter tests
  • isolated Windows-specific cross-compilation check

Full-project Windows cross-compilation was blocked locally by missing Windows C headers required by zstd-sys.

Apply one deadline to process execution and stdout collection, abort immediately when output exceeds the cap, and contain Windows adapters in a kill-on-close job before resuming them.
@ryanfowler
ryanfowler force-pushed the fix/external-image-adapter-timeout branch from 5853578 to 3fbde71 Compare July 18, 2026 11:38
@ryanfowler
ryanfowler merged commit dfcdc1d into main Jul 18, 2026
4 checks passed
@ryanfowler
ryanfowler deleted the fix/external-image-adapter-timeout branch July 18, 2026 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant