feat: upgrade legible to 0.5.0 and remove htmd dependency - #939
Merged
Conversation
Legible 0.5.0 adds a markdown_content field to Article, providing CommonMark output directly. This lets us remove the htmd dependency that was used solely for HTML-to-Markdown conversion. Also updates documentation references to reflect the simplified pipeline.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Legible 0.5.0 adds a
markdown_contentfield toArticle, providing CommonMark output directly. This lets us remove thehtmddependency that was used solely for HTML-to-Markdown conversion.Changes
legiblefrom 0.4.3 to 0.5.0htmddependency and its 15 transitive dependencieshtmd::convert(&article.content)with&article.markdown_contentmarkdown_contentfield to test struct literalValidation
cargo fmt— cleancargo clippy --locked --all-targets --all-features -- -D warnings— cleancargo test --locked --all-features --lib --bins— 909 passed, 1 pre-existing flaky QUIC timing test unrelated