Issue placing an order

[dieseldaytrades]

First off, awesome project! I've been looking forward to playing around with it and finally found the time.

I'm running into an issue running in live mode, all health checks all passed (I have all of the api keys in .env etc), but I'm running into an issue for a live order to actually be placed it seems:

API request failed without retry [trading_system.kalshiclient] endpoint=/trade-api/v2/portfolio/orders error=HTTP 400: {"error":{"code":"invalid_order","message":"invalid order","details":"exactly one of yes_price, no_price, yes_price_dollars, or no_price_dollars should be provided"}}

Larger log dump below

logs.txt

[ryanfrigo]

This looks like a bug in the order creation logic. The Kalshi API error is clear:

Error: exactly one of yes_price, no_price, yes_price_dollars, or no_price_dollars should be provided

Root cause: The order payload is likely including multiple price fields or missing them entirely.

For @ryanfrigo: This suggests an issue in the order creation code where:

1. Both yes_price and no_price are being sent, or
2. Price fields are being sent as null/empty, or
3. The wrong price field format is being used

Quick debugging for @dieseldaytrades:
Can you check the actual order payload being sent? Look for log lines right before the 400 error - there should be request body details.

Suggested fix: The order creation logic should:

• Choose exactly ONE price field based on the side (YES vs NO)
• Ensure price values are properly formatted (integers for cents, not floats)
• Validate the payload before sending

This is blocking live trading for users, so higher priority to fix.

[ryanfrigo]

🐛 Issue Fixed!

Problem Identified:
The order placement code in src/jobs/execute.py was not providing the required price field when placing market orders. The Kalshi API requires exactly one of: yes_price, no_price, yes_price_dollars, or no_price_dollars to be provided, even for market orders.

Root Cause:
The execute_position function was calling place_order without any price parameters:

order_response = await kalshi_client.place_order(
    ticker=position.market_id,
    client_order_id=client_order_id,
    side=position.side.lower(),
    action="buy",
    count=position.quantity,
    type_="market"
    # ❌ Missing: price field based on side
)

Solution Applied:
Modified the function to fetch current market data and provide the appropriate price field based on the position side:

• YES positions → include yes_price using the market's yes_ask price
• NO positions → include no_price using the market's no_ask price
• Added validation to ensure ask prices are valid (> 0) before using them
• Added error handling for markets with no liquidity

Code Changes:

• Modified src/jobs/execute.py to properly construct order parameters
• Added tests/test_issue9_price_field_fix.py with comprehensive test coverage

Verification:
The fix has been tested and verified to correctly construct order parameters. Users should now be able to place live orders without encountering the API error.

Commit: 283f07d

The live trading bug is now resolved! 🎉

[ryanfrigo]

Fixed in commit 283f07d — added required price fields to order payload.