Skip to content

Use pcall in OnIconChanged for proper error handling #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ryanlua merged 4 commits into from
Oct 1, 2025
Merged

Use pcall in OnIconChanged for proper error handling #113

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a8b0509
Use pcall in OnIconChanged for error handling
Epixerty Oct 1, 2025
a6707bd
Merge branch 'main' into patch-1
ryanlua Oct 1, 2025
55a243d
Fix shadowing
ryanlua Oct 1, 2025
f2fe93b
Fix linting
ryanlua Oct 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions src/init.luau
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1481,8 +1481,14 @@ end

local function OnIconChanged(enabled: boolean): ()
-- Check for enabling/disabling the whole thing
task.wait()
enabled = enabled and StarterGui:GetCore("TopbarEnabled")
local success, _topbarEnabled = pcall(function()
return enabled and StarterGui:GetCore("TopbarEnabled")
end)

if not success then
return
end

WholeThingEnabled = enabled
MainFrame.Visible = enabled

Expand Down