feat: Test Connection button and descriptive provider error states#628
Merged
Conversation
release: v2.3.5 stable
chore: regenerate Gitleaks baseline for v2.3.5
- Add POST /api/providers/{providerId}/test Monitor endpoint
- Add ProviderTestRequest model and route constants
- Add TestProviderConnectionAsync to IMonitorService/MonitorService
- Add GetProviderService lookup to ProviderManager
- Add Test button in Settings UI for StandardApiKey providers
- Shows inline success/failure result after testing
Contributor
|
This PR contains 4572 lines changed across 39 files. Details:
Recommendation: This is an automated message. Feel free to ignore if this PR is intentionally large. |
- ProviderBase: auto-attach HttpFailureContext in FetchJsonAsync error paths (HTTP status, network, timeout, deserialization failures) - ProviderBase: attach FailureContext in CreateUnavailableUsageFromStatus, CreateUnavailableUsageFromException, CreateUnavailableUsageFromProviderException - Presentation: read FailureContext.Classification to show actionable messages (e.g. 'Invalid API key' vs 'Network error' vs 'Rate limited') - Reuses existing HttpFailureClassification enum instead of adding new ProviderErrorType
Contributor
|
This PR contains 4650 lines changed across 41 files. Details:
Recommendation: This is an automated message. Feel free to ignore if this PR is intentionally large. |
rygel
pushed a commit
that referenced
this pull request
Jun 11, 2026
Pre-existing gap: the provider test endpoint was added in task-41 (C12) but never documented in the OpenAPI contract. The contract drift check has been failing since PR #628 merged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Task 41: Test Connection Button (P1)
Task 42: Descriptive Error States (P2)
Testing