Cycle 23 Core: Move ProviderMetadataCatalog to Core + fix BetaUpdateCheck suffix#677
Merged
Conversation
ParseAppVersion was parsing '1-develop' (from e.g. v2.3.7-beta.1-develop) as a single int, which failed TryParse and defaulted to 0 — making newer betas appear older than their predecessors. Fix: extract the numeric portion before any additional suffix. Added 6 test cases for -develop suffix parsing and comparison.
Move ProviderMetadataCatalog.cs to Core/Providers/ namespace. The Initialize(Assembly) pattern from C22 task-99 enables this — composition roots pass the Infrastructure assembly so the catalog scans for provider implementations correctly. Changes: - Moved ProviderMetadataCatalog.cs to Core/Providers/ - Updated 42 files with using AIUsageTracker.Core.Providers - Updated Monitor Program.cs and Web WebApplicationBootstrapper to pass typeof(ProviderRegistrationExtensions).Assembly to Initialize - Added ModuleInitializer in Tests and Monitor.Tests projects to call Initialize before any test accesses Definitions - Updated Definitions_AreDiscoveredFromProviderClasses test to scan Infrastructure assembly via typeof(GroqProvider).Assembly - All 1554 tests pass (1413 + 141)
The ProviderMetadataCatalog move to Core broke the Slim UI - it was relying on the fallback that scanned the Infrastructure assembly (where the catalog previously lived). Now that the catalog is in Core, the fallback scans Core which has no providers, causing an empty catalog and screenshot rendering failures. Added ProviderMetadataCatalog.Initialize(typeof(ProviderRegistrationExtensions).Assembly) call in ConfigureServices, before any service registration.
Settings providers page renders at a different height now that ProviderMetadataCatalog.Initialize correctly discovers all providers in the Slim UI. Sync baseline from CI candidate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Verification