Preserve UI data across sleep/hibernate resume#682
Merged
Conversation
Two fixes for the post-hibernate data wipe: 1. OnPowerModeChanged now triggers a refresh and switches to rapid polling on resume, instead of just logging. The old code did nothing, leaving the timer to fire whenever it next ticked. 2. ApplyFetchedUsages guards against overwriting available data with all-unavailable data. After hibernate, the Monitor may serve zero-value entries while providers reconnect. The guard preserves the last known good data until at least one provider becomes available again, showing a 'reconnecting...' status instead. Root cause: OnPowerModeChanged(PowerModes.Resume) was a no-op. The polling timer would eventually fire, but the Monitor's refresh cycle could return error/zero responses while the network was still initializing, and ApplyFetchedUsages would blindly overwrite good cached data with those zeros.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
After hibernate/sleep, the UI showed zeros instead of keeping cached data. Users had to wait for fresh data while staring at an empty dashboard.
Root Cause
Fix