Fix reset credits propagation: lift to parent instead of digging into child cards#707
Merged
Merged
Conversation
…ad of digging into child cards
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The previous fix (PR #706) added a
ResolveResetCreditsmethod that dug intoWindowCardsto find the burst card'sResetCreditsAvailable. This is the exact same pattern of parent-reaching-into-child we've explicitly been told to avoid.Fix
Root cause:
GroupedUsageDisplayAdapter.Expandcreates aWindowedProviderUsagebut never propagatesResetCreditsAvailablefrom the child burst card to the parent.Solution: Set
ResetCreditsAvailableon theWindowedProviderUsageparent at construction time in the adapter. The tooltip code now just checksusage.ResetCreditsAvailablelike every other provider — no child-digging needed.Changed files:
GroupedUsageDisplayAdapter.cs: Propagate burst card'sResetCreditsAvailableto parentWindowedProviderUsageMainWindowRuntimeLogic.cs: RevertResolveResetCredits, go back to simpleusage is QuotaProviderUsage qResetcheck