-
-
Notifications
You must be signed in to change notification settings - Fork 319
chore(docs): eslint config #652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Caution Review failedThe pull request is closed. WalkthroughThe PR updates docs/eslint.config.js to switch the ESLint preset type from 'lib' to 'app' and removes the ignores array. It also adds two ESLint disable comments to docs/update-api-index.ts to permit top-level await and console usage. No runtime logic changes. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
✨ Finishing touches
🧪 Generate unit tests
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary of ChangesHello @ryoppippi, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refines the ESLint configuration within the documentation section of the project. It adjusts the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the ESLint configuration for the docs package. The configuration type is changed to 'app', and the explicit ignores list is removed. This seems intended to rely on defaults from the shared configuration and to start linting the update-api-index.ts script. The script is also updated with eslint-disable comments to handle rules it violates by design. My review includes a suggestion to explicitly ignore generated documentation and public asset directories to prevent potential issues with linting generated or non-source files.
| type: 'lib', | ||
| type: 'app', | ||
| svelte: false, | ||
| markdown: true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While changing the config type to 'app' and removing most of the ignores makes sense, it might be prudent to keep ignoring the api/** and public/** directories.
- The
api/**directory contains documentation generated by TypeDoc. Linting generated files can lead to errors that should be fixed in the generator, not in the output files, and any manual fixes would be overwritten. - The
public/**directory typically contains static assets that don't require linting.
Explicitly ignoring these directories would make the configuration more robust.
markdown: true,
ignores: [
'api/**',
'public/**',
],
Summary by CodeRabbit
Chores
Documentation