Skip to content

Conversation

@ryoppippi
Copy link
Owner

@ryoppippi ryoppippi commented Sep 21, 2025

Summary

  • Updated @ryoppippi/eslint-config from previous version to 0.4.0
  • Removed svelte: false from all eslint.config.js files since svelte is now disabled by default

Changes

  • Updated package dependency to latest version (0.4.0)
  • Removed redundant svelte: false configuration from:
    • Root eslint.config.js
    • apps/ccusage/eslint.config.js
    • apps/mcp/eslint.config.js
    • apps/codex/eslint.config.js
    • docs/eslint.config.js
    • packages/terminal/eslint.config.js
    • packages/internal/eslint.config.js

Test plan

  • All eslint configurations updated
  • Run format command to verify configuration works
  • CI tests pass

Summary by CodeRabbit

  • Chores
    • Updated lint configuration to @ryoppippi/eslint-config v0.4.0 and aligned workspace catalog references.
    • Simplified ESLint setups across apps, packages, and docs by relying on default settings; removed explicit Svelte disable flags.
    • No runtime or user-facing behavior changes; developer linting experience becomes more consistent.

@coderabbitai
Copy link

coderabbitai bot commented Sep 21, 2025

Warning

Rate limit exceeded

@ryoppippi has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 23 minutes and 56 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 9342a5e and e58050c.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (9)
  • apps/ccusage/eslint.config.js (0 hunks)
  • apps/codex/eslint.config.js (0 hunks)
  • apps/mcp/eslint.config.js (0 hunks)
  • docs/eslint.config.js (0 hunks)
  • eslint.config.js (0 hunks)
  • package.json (1 hunks)
  • packages/internal/eslint.config.js (0 hunks)
  • packages/terminal/eslint.config.js (0 hunks)
  • pnpm-workspace.yaml (1 hunks)

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

Walkthrough

Removed the explicit svelte: false option from multiple ESLint config files and updated the workspace catalog to @ryoppippi/eslint-config ^0.4.0, with a corresponding devDependency alias tweak in package.json. No other configuration structures or exports were changed.

Changes

Cohort / File(s) Summary of Changes
ESLint configs: remove svelte option
apps/ccusage/eslint.config.js, apps/codex/eslint.config.js, apps/mcp/eslint.config.js, docs/eslint.config.js, packages/internal/eslint.config.js, packages/terminal/eslint.config.js, eslint.config.js
Removed svelte: false from the object passed to ryoppippi; other config content unchanged.
Workspace catalog bump
pnpm-workspace.yaml
Updated catalogs.lint entry for @ryoppippi/eslint-config from ^0.3.7 to ^0.4.0.
DevDependency alias tweak
package.json
Changed @ryoppippi/eslint-config devDependency value from "catalog:lint" to "catalog:".

Sequence Diagram(s)

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Poem

I nibbled configs, neat and small,
Plucked “svelte: false” from every wall.
Hopped to the workspace, bumped the tag,
Catalog trails in tidy swag.
With lint winds calm and carrots bright,
This bunny’s build now squeaks just right. 🥕✨

✨ Finishing touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch update-eslint-config

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @ryoppippi, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on modernizing the project's ESLint setup by upgrading the primary configuration package and removing unnecessary Svelte-related settings. This streamlines the linting process and ensures the project benefits from the latest features and fixes in the ESLint ecosystem. Additionally, a range of other development dependencies have been brought up to date.

Highlights

  • ESLint Configuration Update: The core @ryoppippi/eslint-config package has been updated to version 0.4.0.
  • Svelte Configuration Simplification: Redundant svelte: false configurations have been removed from all eslint.config.js files, as Svelte support is now disabled by default in the updated ESLint configuration.
  • Dependency Updates: Several other development dependencies, including various @typescript-eslint packages, @stylistic/eslint-plugin, @vitest/eslint-plugin, and browser-related packages like browserslist and caniuse-lite, have been updated to their latest versions.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@socket-security
Copy link

socket-security bot commented Sep 21, 2025

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updated@​ryoppippi/​eslint-config@​0.3.7 ⏵ 0.4.076 -110077 +291 +7100

View full report

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Sep 21, 2025

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
✅ Deployment successful!
View logs
ccusage-guide e58050c Sep 21 2025, 04:53 PM

@pkg-pr-new
Copy link

pkg-pr-new bot commented Sep 21, 2025

Open in StackBlitz

npm i https://pkg.pr.new/ryoppippi/ccusage@659
npm i https://pkg.pr.new/ryoppippi/ccusage/@ccusage/codex@659
npm i https://pkg.pr.new/ryoppippi/ccusage/@ccusage/mcp@659

commit: e58050c

@pkg-pr-new
Copy link

pkg-pr-new bot commented Sep 21, 2025

Open in StackBlitz

npm i https://pkg.pr.new/ryoppippi/ccusage@659
npm i https://pkg.pr.new/ryoppippi/ccusage/@ccusage/codex@659
npm i https://pkg.pr.new/ryoppippi/ccusage/@ccusage/mcp@659

commit: d92b5ac

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the @ryoppippi/eslint-config dependency to version 0.4.0 and cleans up the ESLint configuration files by removing the svelte: false option, which is now the default. The changes are clear and align with the stated goals. I've identified a minor issue with a redundant dependency definition in pnpm-workspace.yaml that should be addressed to improve maintainability.

@@ -4,6 +4,7 @@ packages:
- packages/*

catalog:
'@ryoppippi/eslint-config': 0.4.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

By moving @ryoppippi/eslint-config to the default catalog, the old entry in the lint catalog (on line 28) has become redundant. To avoid confusion and keep the configuration clean, please remove the old entry.

…te=false

- Updated @ryoppippi/eslint-config in lint catalog from ^0.3.7 to ^0.4.0
- Removed svelte: false from all eslint.config.js files as it's now
default false
- Removed unused @ryoppippi/eslint-config entry from default catalog
- Changes affect root, apps/ccusage, apps/mcp, apps/codex, docs,
packages/terminal, and packages/internal
@ryoppippi ryoppippi changed the title deps: update @ryoppippi/eslint-config to 0.4.0 and remove svelte=false chore: update @ryoppippi/eslint-config to 0.4.0 and remove svelte=false Sep 21, 2025
@ryoppippi ryoppippi merged commit 3ed63f9 into main Sep 21, 2025
14 of 16 checks passed
@ryoppippi ryoppippi deleted the update-eslint-config branch September 21, 2025 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants