* fix(journal): strip NODE_OPTIONS launch banner from plainified PR titles (#1093) The orchestrator's fallback commit-message generator can lift the agent's first stdout line verbatim, so a PR title occasionally *is* the `ℹ NODE_OPTIONS=… (saved preference)` Copilot CLI launch banner (observed on leaked commits, e.g. `9a7e88ec8 fix: ℹ NODE_OPTIONS=…`). The journal's `plainify_pr_title` surfaced that banner to laypeople as a "what changed & why it matters" phrase. Route the (prefix-stripped) title through the existing shared `recipe_output::strip_recipe_noise` predicate — the same filter that already suppresses this banner on every other channel — so a banner-only title collapses to the neutral "A code change." fallback. Reuses the shared predicate rather than adding a new regex; the banner arm anchors on the full shape (`ℹ` + `NODE_OPTIONS=` + `(saved preference)`), so a real title that merely mentions NODE_OPTIONS in prose is preserved (anti-weakening). RED-first tests: - plain_summary_drops_node_options_launcher_banner_title (feat: + fix:) - plain_summary_preserves_title_that_merely_mentions_node_options (guard) Docs: note the new journal PR-title consumer in the shared-noise-filter reference and journal-api reference. Out of scope (filed as #4974): consolidating the remaining local ANSI strippers (transcript.rs CSI-only, distributed.rs, ooda_brain/sanitize.rs) into the shared recipe_output::strip_ansi. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * feat: ℹ NODE_OPTIONS=--max-old-space-size=32768 (saved preference). To chang Implements issue #1093 Changes: - Implementation as per design specification - Tests added for new functionality - Documentation updated Closes #1093 --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

verify existing issue #915 #1093

Description

Metadata

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

Issue actions