chore(deps): bump amplihack-memory to #129 + repoint lbug to fork (lbug portability fix #3119) - #3171
Merged
Merged
Conversation
… (lbug portability fix, #3119) Consumes amplihack-memory-lib #129 (rev 5807d056): the lbug portability fix. Published crates.io lbug 0.17.1 SIGSEGVs in std::vformat during Database::initBufferManager on hosts whose libstdc++ std::format ABI differs from the prebuilt (Ubuntu 26.04), and its build.rs double-links the bundled third-party archives in source mode (duplicate symbols). The fix pins lbug to the rysweet/ladybug-rust fork (link_bundled_deps=false, links only the self-contained liblbug.a): from-source cures the ABI SIGSEGV and links cleanly with no unsafe --allow-multiple-definition. Simard's direct `lbug` dep (used by simard-tui's read-only goal-board reader) is repointed at the SAME fork rev so cargo unifies to exactly one lbug crate / one engine / one storage format. Verified: Cargo.lock has a single lbug (0.17.0, fork); `cargo build --bin simard --bin simard-tui` succeeds. The fork engine writes on-disk format v42 (forward-only from v41). This unblocks running Simard-family agents (Crocutus, the platform installer) from source on newer-libstdc++ hosts. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…ork git dep The pin-bump broke three guards in issue_2626_amplihack_pin_bump.rs: - MEMORY_TARGET_REV was the old 72c5ea1b (#126); bump it to 5807d056 (#129, the lbug portability fix) and move MEMORY_STALE_REV to 72c5ea1b as the new anti-regression sentinel. - direct_lbug_pin_matches_the_single_locked_version assumed lbug is a crates.io `= "=X"` version pin. lbug is now a git dep on the rysweet/ladybug-rust fork, so the guard now asserts the direct lbug is a git dep on the fork remote at the expected full-SHA rev AND that Cargo.lock resolves exactly one lbug from that fork rev (single engine / one store format — the invariant is unchanged). All 9 guards pass locally. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This was referenced Jul 8, 2026
Open
rysweet
added a commit
that referenced
this pull request
Jul 8, 2026
…3119 regression) (#3228) The lbug portability fix (#3171) changed the direct `lbug` dependency from a crates.io version pin (`lbug = "=0.17.1"`) to a git dependency on the rysweet/ladybug-rust fork. That broke `scripts/provision-lbug-prebuilt.sh`'s `lbug_version()`, which only parsed a `lbug = "=X.Y.Z"` manifest line — it now returns empty, so the coverage CI job (and the pre-commit clippy wrapper) die with "could not determine lbug version from Cargo.toml" on every PR off main. Fall back to the resolved version in Cargo.lock (`[[package]] name = "lbug"` -> `version = "0.17.0"`) when the manifest line carries no version. Verified the patched parser resolves 0.17.0 from the current git-dep manifest. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Prebuilt
lbug 0.17.1SIGSEGVs instd::vformatduringDatabase::initBufferManageron hosts whose libstdc++std::formatABI differs from the prebuilt (Ubuntu 26.04), and itsbuild.rsdouble-links the bundled third-party archives in source mode (duplicate symbols). This blocked running Simard-family agents (Crocutus, the platform installer) on modern hosts.Fix
Consumes amplihack-memory-lib #129 (rev
5807d056), which pinslbugto therysweet/ladybug-rustfork (build.rskeepslink_bundled_deps=false, links only the self-containedliblbug.a). Building from source both cures the ABI SIGSEGV and links cleanly — no unsafe--allow-multiple-definition.Simard's direct
lbugdep (simard-tui's read-only goal-board reader) is repointed at the same fork rev so cargo unifies to exactly onelbugcrate / one engine / one storage format.Verification
Cargo.lockhas a singlelbug(0.17.0, fork) — no dual enginecargo build --bin simard --bin simard-tuisucceeds;cargo clippy --release -D warningsclean--features persistentlinks clean, all 54lbug_storetests pass (fork engine writes on-disk format v42, forward-only from v41; the no-data-loss gate now accepts v41-or-newer)Fixes Simard #3119.
Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com