fix: harden terminal-shell shell validation - #39
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This was referenced Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
terminal-shellsoshell:only accepts an absolute executable path made of safe path charactersscript -claunch stringshell:input is rejected without creating the injected side-effect fileWhy
PR #37 introduced
terminal-shell, but the initial shell normalization logic still allowed command-substitution-style metacharacters such as$()to flow into thescript -claunch command. That made command injection possible through the operator-facing objective.Validation
cargo fmt --allcargo test --all-features --lockedtests/gadugi/terminal-session.shtests/gadugi/smoke-explicit-local.shtests/gadugi/smoke-explicit-rusty-clawd.shtests/gadugi/smoke-builtin-defaults.shtests/gadugi/composite-identity.shtests/gadugi/meeting-mode.shtests/gadugi/handoff-roundtrip.shtests/gadugi/review-mode.shtests/gadugi/gym-suite.shpython3 -m pre_commit run --all-files --hook-stage pre-commitpython3 -m pre_commit run --all-files --hook-stage pre-pushCloses #38.