fix: resolve symlinks when locating script dir - #3
Merged
Conversation
The symlink install method (~/.local/bin/cmdr -> repo/cmdr.sh) broke because SCRIPT_DIR used dirname of BASH_SOURCE without resolving the symlink, so cmdr_functions.sh was looked up in ~/.local/bin instead of the repo. Walk the symlink chain to find the real install directory. Claude-Session: https://claude.ai/code/session_01By6TY3ZCJmYmCqv1LSwGU3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The installer's symlink method (
~/.local/bin/cmdr -> repo/cmdr.sh) was broken.SCRIPT_DIRuseddirname "${BASH_SOURCE[0]}"without resolving the symlink, socmdr_functions.shwas looked up in~/.local/bininstead of the repo:The code comment even claimed it "follows symlinks" but it didn't.
Fix
Walk the symlink chain to resolve the real install directory before computing
SCRIPT_DIR.Test
ln -sf repo/cmdr.sh ~/.local/bin/cmdrthencmdr -hnow works../cmdr.shinvocation unaffected.https://claude.ai/code/session_01By6TY3ZCJmYmCqv1LSwGU3