feat(tui): pills for known basin locations in create form

[cristi-]

Fetches list_locations lazily on first CreateBasin open and renders the result as pills ([Default] [aws:us-east-1] … [Custom…]). Falls back to today's freeform text input if the fetch fails or returns empty.

[greptile-apps]

Greptile Summary

Adds lazy list_locations fetching and renders the result as pill selectors ([Default] [aws:us-east-1] … [Custom…]) in the CreateBasin dialog, falling back to freeform text input when the fetch fails or returns empty.

• app.rs: loads locations on first CreateBasin open, stores them on App, handles Left/Right to cycle pills, and dispatches a new LocationsLoaded event.
• ui.rs: renders the pill row and conditionally shows a text-input row beneath it when "Custom…" is active; contains duplicated pill-index logic that also lives in app.rs.
• event.rs / ci.yml: adds the new event variant and skips location API tests in CI.

Confidence Score: 3/5

The Custom pill — the core interactive feature introduced by this PR — is unreachable via keyboard navigation when known locations are loaded.

set_location_for_pill clears location on the Custom slot, but an empty string maps back to Default in location_pill_idx(), so the Custom pill can never appear highlighted and the custom text-input row never renders.

cli/src/tui/app.rs — specifically set_location_for_pill and its interaction with the location_pill_idx closure

Important Files Changed

Filename	Overview
cli/src/tui/app.rs	Adds location loading, pill-navigation keyboard handling, and set_location_for_pill; the helper incorrectly clears location for the Custom pill, making that pill unselectable via keyboard.
cli/src/tui/ui.rs	Renders location pills with a conditional custom text-input row; duplicates the pill-index computation that also lives in app.rs.
cli/src/tui/event.rs	Adds the LocationsLoaded event variant; straightforward and correct.
.github/workflows/ci.yml	Skips location-related tests in Go and Python CI runs, consistent with the pattern used for other credential-dependent tests.

Sequence Diagram

sequenceDiagram
    participant U as User
    participant App
    participant API as s2 API

    U->>App: press 'c' (CreateBasin)
    App->>App: locations.is_none()?
    App->>API: list_locations()
    API-->>App: LocationsLoaded(Ok(locs))
    App->>App: "self.locations = Some(locs)"

    U->>App: navigate to field 1 (Location)
    App->>App: render pills [Default][aws:us-east-1][Custom…]

    U->>App: press Right
    App->>App: "new_idx = 1"
    App->>App: "set_location_for_pill sets location = known_locs[0]"

    U->>App: press Right again (toward Custom)
    App->>App: "new_idx = custom_idx"
    App->>App: set_location_for_pill clears location (bug)
    App->>App: location_pill_idx returns 0 (Default) instead of custom_idx

    U->>App: press Enter to submit
    App->>API: create_basin with empty location

Loading

Prompt To Fix All With AI

Fix the following 2 code review issues. Work through them one at a time, proposing concise fixes.

---

### Issue 1 of 2
cli/src/tui/app.rs:1022-1027
**Custom pill unreachable via keyboard navigation**

`set_location_for_pill` calls `location.clear()` when `pill_idx == custom_idx`, but `location_pill_idx()` maps an empty string back to index 0 (Default), not to `custom_idx`. After pressing Right to reach "Custom…", the app's state is identical to having Default selected, so the pill row renders with Default highlighted and the custom text-input row never appears. Because `location_pill_idx()` immediately evaluates to 0, the `editable` guard in the Enter handler also rejects entry to edit mode for the Custom slot.

The `location` field alone cannot encode three distinct states (Default = `""`, known location = its name, Custom-but-empty = ???). A separate flag or sub-enum for the current pill selection would resolve the ambiguity without changing the submitted value semantics.

### Issue 2 of 2
cli/src/tui/ui.rs:4620-4631
**Duplicated pill-index computation**

The mapping from `location` string → active pill index is computed independently here (in `draw_input_dialog`) and in the `location_pill_idx` closure inside `handle_input` in `app.rs`. If the logic ever diverges (e.g., a new sentinel value is added), the rendered highlight and the keyboard navigation cursor will disagree silently. Extracting this into a small shared helper — or passing a pre-computed index through `InputMode` — would keep the two sites in sync.

_{Reviews (1): Last reviewed commit: "maybe" | Re-trigger Greptile}

[greptile-apps]

Custom pill unreachable via keyboard navigation

set_location_for_pill calls location.clear() when pill_idx == custom_idx, but location_pill_idx() maps an empty string back to index 0 (Default), not to custom_idx. After pressing Right to reach "Custom…", the app's state is identical to having Default selected, so the pill row renders with Default highlighted and the custom text-input row never appears. Because location_pill_idx() immediately evaluates to 0, the editable guard in the Enter handler also rejects entry to edit mode for the Custom slot.

The location field alone cannot encode three distinct states (Default = "", known location = its name, Custom-but-empty = ???). A separate flag or sub-enum for the current pill selection would resolve the ambiguity without changing the submitted value semantics.

Prompt To Fix With AI

This is a comment left during a code review.
Path: cli/src/tui/app.rs
Line: 1022-1027

Comment:
**Custom pill unreachable via keyboard navigation**

`set_location_for_pill` calls `location.clear()` when `pill_idx == custom_idx`, but `location_pill_idx()` maps an empty string back to index 0 (Default), not to `custom_idx`. After pressing Right to reach "Custom…", the app's state is identical to having Default selected, so the pill row renders with Default highlighted and the custom text-input row never appears. Because `location_pill_idx()` immediately evaluates to 0, the `editable` guard in the Enter handler also rejects entry to edit mode for the Custom slot.

The `location` field alone cannot encode three distinct states (Default = `""`, known location = its name, Custom-but-empty = ???). A separate flag or sub-enum for the current pill selection would resolve the ambiguity without changing the submitted value semantics.

How can I resolve this? If you propose a fix, please make it concise.

[greptile-apps]

Duplicated pill-index computation

The mapping from location string → active pill index is computed independently here (in draw_input_dialog) and in the location_pill_idx closure inside handle_input in app.rs. If the logic ever diverges (e.g., a new sentinel value is added), the rendered highlight and the keyboard navigation cursor will disagree silently. Extracting this into a small shared helper — or passing a pre-computed index through InputMode — would keep the two sites in sync.

Prompt To Fix With AI

This is a comment left during a code review.
Path: cli/src/tui/ui.rs
Line: 4620-4631

Comment:
**Duplicated pill-index computation**

The mapping from `location` string → active pill index is computed independently here (in `draw_input_dialog`) and in the `location_pill_idx` closure inside `handle_input` in `app.rs`. If the logic ever diverges (e.g., a new sentinel value is added), the rendered highlight and the keyboard navigation cursor will disagree silently. Extracting this into a small shared helper — or passing a pre-computed index through `InputMode` — would keep the two sites in sync.

How can I resolve this? If you propose a fix, please make it concise.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!