feat(setup): add robust input validation for user prompts - #1
Merged
Conversation
…mpty feat(setup): add input validation to ensure required fields are not empty
s403o
self-requested a review
June 14, 2025 19:47
s403o
reviewed
Jun 14, 2025
s403o
left a comment
Owner
There was a problem hiding this comment.
@talaatmagdyx Thanks for the contribution! I've tested the changes, and everything works as expected. Looks good to me!
s403o
added a commit
that referenced
this pull request
Jul 30, 2026
feat(setup): add robust input validation for user prompts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This PR enhances the
gitmerightsetup script by introducing input validation to ensure that all required user inputs (GitHub username, full names, emails, and project names) are not left empty.🔧 Changes Introduced:
Added a reusable
prompt_and_validateBash function that:Replaced all
read -pprompts with the new validation wrapper to enforce required input.Improved the user experience by displaying clear error messages for missing input.
✅ Benefits:
.gitconfigfiles due to empty placeholders.🧪 Testing:
.gitconfigfiles are correctly populated and no silent failures occur.