Device-true units in every readout + consent-gated full (taper) capture#78
Merged
Conversation
…affordance Devices advertising fullCapture get a secondary 'Full capture (knob tapers)' action behind an explicit consent panel (writes test values into the current preset, reloads after, nothing saved); build() plumbs mode:'full' through the client. AxisPanel gains 'Re-read definitions' for firmware updates. Unknown SSE build phases (e.g. param-sweep) now count as progress, fixing a latent false-terminal bug.
sKuhLight
enabled auto-merge
July 20, 2026 14:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
withUnit/fmtValueformatters: every device-true unit token renders verbatim (dB, dB/OCT, dBu, dBV, SECONDS, SAMPLES; Hz→kHz stays the only conversion); fixes the63 %vs63%inconsistency between bubble and knob face.fullCapturecapability;modeplumbed throughdeviceDefs.build()→forgefx.buildDeviceCache()→ POST body. The read-only one-click build is byte-for-byte unchanged.deleteDeviceCache— the firmware-update path.param-sweep) now count as progress — fixes a latent false-terminal bug inonBuildEvent.Verification
npm run check0 errors / 0 warnings;npm test1111 tests green (includes new format + deviceDefs + client suites). No e2e needed — all changes are mocked-layer testable.Notes
Server counterpart (fullCapture caps + build mode) lands via ForgeFX
feature/definition-completeness; until then the new action simply never appears (caps-gated), so this PR is safe to merge independently withrelease:none— the features ship with the next stack pin release.Plane: AXIS-61, AXIS-62 (Done).