refactor(src): delete dead mod.rs Jira wrappers (-432 LOC)#82
Merged
refactor(src): delete dead mod.rs Jira wrappers (-432 LOC)#82
Conversation
commands/mod.rs had 10 Jira-related functions + two constants that shadowed src-tauri/src/commands/jira_commands.rs. The registry (registry.rs:205-211 and the post_and_transition entry) points at jira_commands::* directly — neither block in mod.rs was registered nor called from anywhere else. Leftover from an older layout that moved Jira commands into their own file but never deleted the originals. Four of the deleted wrappers (is_jira_configured, get_jira_config, configure_jira, clear_jira_config) were pure delegations to jira_commands::*_impl; the other six (get_jira_ticket, add_jira_comment, push_draft_to_jira, get_jira_transitions, transition_jira_ticket, post_and_transition) were full reimplementations that duplicated the DB queries and HTTP calls. Also removed the now-unused TOKEN_JIRA import and the unused validate_ticket_id import (the latter was only consumed by the deleted duplicates). mod.rs: 6022 lines -> 5593 lines (-432 LOC net of the two +2 lines of cleanups to the use statements). Verified: - cargo check --all-targets clean (no warnings) - cargo test --lib: 311 pass, 1 ignored - cargo test --test command_contracts: 8 pass Follow-up to PR #81 which left the dead block in place as temporary compile-bridging scaffolding.
This was referenced Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
commands/mod.rshad 10 Jira-related functions and two constants that shadowedsrc-tauri/src/commands/jira_commands.rs. Neither block was registered (the registry points atjira_commands::*directly) nor called from anywhere else — pure dead code from an older layout where the Jira commands were duplicated in both places.is_jira_configured,get_jira_config,configure_jira,clear_jira_config) were pure delegations tojira_commands::*_impl. PR refactor(src): migrate jira commands to AppError with From<JiraError> #81 added temporary.map_err(|e| e.to_string())bridges to keep them compiling during the error-type migration; this PR removes them entirely.get_jira_ticket,add_jira_comment,push_draft_to_jira,get_jira_transitions,transition_jira_ticket,post_and_transition) were full reimplementations with their own DB queries and HTTP calls — genuine duplicates with zero delegations.Also removed:
TOKEN_JIRAimport (only referenced inside the deleted blocks)validate_ticket_idimport (same)Impact
mod.rs: 6022 → 5593 lines (−432 LOC net of the two cleanup lines)Test plan
cargo check --all-targets— clean (zero warnings)cargo test --lib— 311 pass, 1 ignoredcargo test --test command_contracts— 8 pass🤖 Generated with Claude Code