Skip to content

refactor(src): delete dead ops-analytics wrappers (-535 LOC)#85

Merged
saagpatel merged 1 commit intomasterfrom
codex/refactor/delete-dead-ops-wrappers
Apr 22, 2026
Merged

refactor(src): delete dead ops-analytics wrappers (-535 LOC)#85
saagpatel merged 1 commit intomasterfrom
codex/refactor/delete-dead-ops-wrappers

Conversation

@saagpatel
Copy link
Copy Markdown
Owner

Summary

Third dead-code sweep in commands/mod.rs — same pattern as PR #82 (Jira) and PR #83 (Jobs). Three unregistered, uncalled blocks of analytics/deployment/eval wrappers that shadow operations_analytics_commands.rs.

Deleted:

  • mod.rs:2047-2076audit_response_copy_override (+ preceding doc comment)
  • mod.rs:4135-4621 — "Phase 4: Response Rating Commands" section header + 21 wrappers: rate_response, get_draft_rating, get_rating_stats, log_analytics_event, get_analytics_summary, get_response_quality_summary, get_response_quality_drilldown_examples, get_kb_usage_stats, get_low_rating_analysis, get_kb_gap_candidates, update_kb_gap_status, run_deployment_preflight, record_deployment_artifact, get_deployment_health_summary, list_deployment_artifacts, verify_signed_artifact, rollback_deployment_run, run_eval_harness, list_eval_runs, cluster_tickets_for_triage, list_recent_triage_clusters
  • mod.rs:4878-4895 — "Phase 2 v0.4.0: Actionable Analytics Commands" section header + get_analytics_for_article

Impact

  • mod.rs: 5108 → 4573 lines (−535 LOC)
  • Zero runtime behavior change — registry points at operations_analytics_commands::* directly
  • No top-level import cleanup needed (the use crate::audit::{...} was function-local inside audit_response_copy_override)

mod.rs shrinkage this session

PR Deleted
#82 (Jira) −432
#83 (Jobs) −484
#85 (Ops-analytics) — this PR −535
Total −1,451 LOC

Test plan

  • Verified via grep that every reference to the deleted symbols is either the definition itself, inside the deleted blocks, or an unrelated DB-layer method with the same name
  • cargo check --all-targets — clean, zero warnings
  • cargo test --lib — 311 pass, 1 ignored
  • cargo test --test command_contracts — 8 pass

🤖 Generated with Claude Code

commands/mod.rs had three dead blocks of analytics / deployment / eval
wrappers that duplicate operations_analytics_commands.rs. Same pattern
cleaned up in PR #82 (Jira) and PR #83 (Jobs). Neither block was
registered (registry.rs:247-277 points at
operations_analytics_commands::* directly), neither was called from
anywhere else.

Deleted:
- mod.rs:2047-2076 — audit_response_copy_override (with preceding doc
  comment)
- mod.rs:4135-4621 — "Phase 4: Response Rating Commands" section:
  rate_response, get_draft_rating, get_rating_stats,
  log_analytics_event, get_analytics_summary,
  get_response_quality_summary,
  get_response_quality_drilldown_examples, get_kb_usage_stats,
  get_low_rating_analysis, get_kb_gap_candidates, update_kb_gap_status,
  run_deployment_preflight, record_deployment_artifact,
  get_deployment_health_summary, list_deployment_artifacts,
  verify_signed_artifact, rollback_deployment_run, run_eval_harness,
  list_eval_runs, cluster_tickets_for_triage,
  list_recent_triage_clusters
- mod.rs:4878-4895 — "Phase 2 v0.4.0: Actionable Analytics Commands"
  section: get_analytics_for_article

mod.rs: 5108 -> 4573 lines (-535). The in-file use crate::audit::{...}
imports that were inside audit_response_copy_override were function-
local so no top-level cleanup needed.

Verified:
- cargo check --all-targets clean, zero warnings
- cargo test --lib: 311 pass, 1 ignored
- cargo test --test command_contracts: 8 pass
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants