refactor(src): delete dead ops-analytics wrappers (-535 LOC)#85
Merged
refactor(src): delete dead ops-analytics wrappers (-535 LOC)#85
Conversation
commands/mod.rs had three dead blocks of analytics / deployment / eval wrappers that duplicate operations_analytics_commands.rs. Same pattern cleaned up in PR #82 (Jira) and PR #83 (Jobs). Neither block was registered (registry.rs:247-277 points at operations_analytics_commands::* directly), neither was called from anywhere else. Deleted: - mod.rs:2047-2076 — audit_response_copy_override (with preceding doc comment) - mod.rs:4135-4621 — "Phase 4: Response Rating Commands" section: rate_response, get_draft_rating, get_rating_stats, log_analytics_event, get_analytics_summary, get_response_quality_summary, get_response_quality_drilldown_examples, get_kb_usage_stats, get_low_rating_analysis, get_kb_gap_candidates, update_kb_gap_status, run_deployment_preflight, record_deployment_artifact, get_deployment_health_summary, list_deployment_artifacts, verify_signed_artifact, rollback_deployment_run, run_eval_harness, list_eval_runs, cluster_tickets_for_triage, list_recent_triage_clusters - mod.rs:4878-4895 — "Phase 2 v0.4.0: Actionable Analytics Commands" section: get_analytics_for_article mod.rs: 5108 -> 4573 lines (-535). The in-file use crate::audit::{...} imports that were inside audit_response_copy_override were function- local so no top-level cleanup needed. Verified: - cargo check --all-targets clean, zero warnings - cargo test --lib: 311 pass, 1 ignored - cargo test --test command_contracts: 8 pass
This was referenced Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Third dead-code sweep in
commands/mod.rs— same pattern as PR #82 (Jira) and PR #83 (Jobs). Three unregistered, uncalled blocks of analytics/deployment/eval wrappers that shadowoperations_analytics_commands.rs.Deleted:
audit_response_copy_override(+ preceding doc comment)rate_response,get_draft_rating,get_rating_stats,log_analytics_event,get_analytics_summary,get_response_quality_summary,get_response_quality_drilldown_examples,get_kb_usage_stats,get_low_rating_analysis,get_kb_gap_candidates,update_kb_gap_status,run_deployment_preflight,record_deployment_artifact,get_deployment_health_summary,list_deployment_artifacts,verify_signed_artifact,rollback_deployment_run,run_eval_harness,list_eval_runs,cluster_tickets_for_triage,list_recent_triage_clustersget_analytics_for_articleImpact
mod.rs: 5108 → 4573 lines (−535 LOC)operations_analytics_commands::*directlyuse crate::audit::{...}was function-local insideaudit_response_copy_override)mod.rs shrinkage this session
Test plan
cargo check --all-targets— clean, zero warningscargo test --lib— 311 pass, 1 ignoredcargo test --test command_contracts— 8 pass🤖 Generated with Claude Code