Twisted uses non-standard C generated by old Pyrex

[jdemeyer]

The file twisted/internet/cfsupport/cfsupport.c (which is only compiled on OS X) is generated by an old version of Pyrex and contains non-standard C. Re-generating this file with Pyrex 0.9.4 solves the problem.

spkg: http://boxen.math.washington.edu/home/jdemeyer/spkg/twisted-9.0.p3.spkg

Component: packages: standard

Author: Jeroen Demeyer

Reviewer: Volker Braun

Merged: sage-5.0.beta6

Issue created by migration from https://trac.sagemath.org/ticket/12425

[jdemeyer]

Description changed:

--- 
+++ 
@@ -1,3 +1,5 @@
 The file `twisted/internet/cfsupport/cfsupport.c` is generated by an old version of Pyrex and contains non-standard C.  Re-generating this file with Pyrex 0.9.4 solves the problem.
 
 We also add a fix for #12422 (add '-Dformat_arg(x)=' to `CFLAGS`).
+
+**spkg**: [http://boxen.math.washington.edu/home/jdemeyer/spkg/twisted-9.0.p3.spkg](http://boxen.math.washington.edu/home/jdemeyer/spkg/twisted-9.0.p3.spkg)

[jdemeyer]

Author: Jeroen Demeyer

[jasongrout]

comment:2

#11874 might also fix this.

[jasongrout]

comment:3

Indeed, that file doesn't appear in Twisted 11.1, so it appears that #11874 might fix this.

[jdemeyer]

comment:4

Replying to @jasongrout:

Indeed, that file doesn't appear in Twisted 11.1, so it appears that #11874 might fix this.

Good. The main motivation for this ticket is #12369, so I don't really care how it gets fixed.

[jdemeyer]

Description changed:

--- 
+++ 
@@ -1,5 +1,3 @@
 The file `twisted/internet/cfsupport/cfsupport.c` is generated by an old version of Pyrex and contains non-standard C.  Re-generating this file with Pyrex 0.9.4 solves the problem.
 
-We also add a fix for #12422 (add '-Dformat_arg(x)=' to `CFLAGS`).
-
 **spkg**: [http://boxen.math.washington.edu/home/jdemeyer/spkg/twisted-9.0.p3.spkg](http://boxen.math.washington.edu/home/jdemeyer/spkg/twisted-9.0.p3.spkg)

[jdemeyer]

Diff for the twisted spkg, for review only

[jdemeyer]

Description changed:

--- 
+++ 
@@ -1,3 +1,3 @@
-The file `twisted/internet/cfsupport/cfsupport.c` is generated by an old version of Pyrex and contains non-standard C.  Re-generating this file with Pyrex 0.9.4 solves the problem.
+The file `twisted/internet/cfsupport/cfsupport.c` (which is only compiled on OS X) is generated by an old version of Pyrex and contains non-standard C.  Re-generating this file with Pyrex 0.9.4 solves the problem.
 
 **spkg**: [http://boxen.math.washington.edu/home/jdemeyer/spkg/twisted-9.0.p3.spkg](http://boxen.math.washington.edu/home/jdemeyer/spkg/twisted-9.0.p3.spkg)

[jdemeyer]

comment:6

Attachment: twisted-9.0.p2-p3.diff.gz

[vbraun]

Reviewer: Volker Braun