update sagetex to version 3.4

[dimpase]

a trivial update

tarball: https://github.com/sagemath/sagetex/releases/download/v3.4/sagetex-3.4.tar.gz

CC: @kcrisman

Component: packages: standard

Author: Dima Pasechnik

Branch/Commit: b79ed33

Reviewer: John Palmieri, Karl-Dieter Crisman

Issue created by migration from https://trac.sagemath.org/ticket/28732

[dimpase]

New commits:

98ffcd0

update sagetex to version 3.4

[dimpase]

Branch: u/dimpase/packages/sagetex34

[dimpase]

Commit: 98ffcd0

[jhpalmieri]

comment:3

Builds and passes its test suite on OS X + Python 3. Works on a sample file of mine. Positive review from me, but people should double check on other platforms.

[kcrisman]

comment:4

Works and passes with SAGE_CHECK on OS X + Python 2 as well! I'd say if someone checks on Linux that would be enough, though hopefully none of the changes would really impact that.

As a side thing, I'll note we receive the following message:

[sagetex-3.4] LaTeX Warning: There were undefined references.
[sagetex-3.4] 
[sagetex-3.4] 
[sagetex-3.4] LaTeX Warning: Label(s) may have changed. Rerun to get cross-references right.
[sagetex-3.4] 
[sagetex-3.4]  )
[sagetex-3.4] (\end occurred inside a group at level 1)
[sagetex-3.4] 
[sagetex-3.4] ### simple group (level 1) entered at line 27 ({)
[sagetex-3.4] ### bottom level
[sagetex-3.4] (see the transcript file for additional information)

which indicates to me that maybe the check script should run pdflatex twice after running Sage, just to resolve those annoying warnings as per usual when TeXing. I don't know about the \end thing because I don't recall seeing that when building example.tex on its own to test.

[jhpalmieri]

comment:5

I see the \end statement with the current version of SageTeX, too, so this is not a regression. It's actually coming from the file sagetex.dtx, not example.tex.

I agree that to produce a good PDF file, you should run pdflatex twice after running sagetex, but we don't actually care about that for testing: we just want to make sure that sagetex seems to be functioning. This would work, but I don't think it's necessary:

diff --git a/build/pkgs/sagetex/spkg-check b/build/pkgs/sagetex/spkg-check
index bc11ad4209..91d965b87f 100644
--- a/build/pkgs/sagetex/spkg-check
+++ b/build/pkgs/sagetex/spkg-check
@@ -33,9 +33,13 @@ cd src
 
 typeset example.tex
 checkdotsage example
+typeset example.tex
+typeset example.tex
 
 typeset sagetex.dtx
 checkdotsage sagetex
+typeset sagetex.dtx
+typeset sagetex.dtx
 
 # if we get here, we assume the .sage files are good, and exit successfully
 exit 0

[dimpase]

comment:6

I have been trying the same patch, and I would add it, as it checks that the Python part of the package functions well and does not produce broken TeX.

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

b79ed33

test that Python output of sagetex is TeX-valid