-
-
Notifications
You must be signed in to change notification settings - Fork 710
Minor refactor for hyperelliptic curve #40528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Documentation preview for this PR (built with commit ea74b42; changes) is ready! 🎉 |
src/sage/schemes/hyperelliptic_curves/hyperelliptic_finite_field.py
Outdated
Show resolved
Hide resolved
src/sage/schemes/hyperelliptic_curves/hyperelliptic_finite_field.py
Outdated
Show resolved
Hide resolved
|
Can you mention the defaults if The generated HTML looks a little bit weird because sphinx puts parentheses after the method name when you use :meth:foo. It might look better if you wrote (for example) :meth:foo with algorithm="pari" instead, but this is just an idea. If you are happy with it, whatever, it's temporary. Otherwise LGTM |
|
how about |
That sounds even better, I didn't know that was an option. |
|
The new docs look great. Please still mention the defaults when |
|
I guess https://github.com/sagemath/sage/pull/39161/files#diff-7647f4a9c65536028428ee1620ece71255c8c4ddc78ecb3db5540de2bb89d047R159 has something similar. (or maybe faster.) haven't checked carefully. |
sagemathgh-40528: Minor refactor for hyperelliptic curve As in the title. See the code for detail. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [ ] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#40528 Reported by: user202729 Reviewer(s): Michael Orlitzky, user202729
sagemathgh-40528: Minor refactor for hyperelliptic curve As in the title. See the code for detail. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [ ] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#40528 Reported by: user202729 Reviewer(s): Michael Orlitzky, user202729
sagemathgh-40528: Minor refactor for hyperelliptic curve As in the title. See the code for detail. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [ ] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#40528 Reported by: user202729 Reviewer(s): Michael Orlitzky, user202729
As in the title. See the code for detail.
📝 Checklist
⌛ Dependencies