Fix libgap(<NumberField>) #40973
Open
Fix libgap(<NumberField>) #40973
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation preview for this PR (built with commit 355e9c3; changes) is ready! 🎉 |
fchapoton
reviewed
Oct 5, 2025
cxzhong
approved these changes
Oct 19, 2025
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Oct 20, 2025
sagemathgh-40973: Fix libgap(<NumberField>) Previously `libgap(QQ[I])` fails. Now it works. also add some minor clean-ups and documentation changes. The pointed out bug (that is, Sage FiniteField ↔ GAP GF does not keep the `DefiningPolynomial`) is to be addressed in a subsequent pull request. context: I was trying to improve the performance of `GF(next_prime(2^128)^4)` by using GAP's `StandardFF` package, see sagemath#38376 (comment). but at the moment the conversion between Sage and Gap FiniteField is wrong. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [ ] The title is concise and informative. - [ ] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#40973 Reported by: user202729 Reviewer(s): Chenxin Zhong, Frédéric Chapoton
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously
libgap(QQ[I])fails. Now it works.also add some minor clean-ups and documentation changes.
The pointed out bug (that is, Sage FiniteField ↔ GAP GF does not keep the
DefiningPolynomial) is to be addressed in a subsequent pull request.context: I was trying to improve the performance of
GF(next_prime(2^128)^4)by using GAP'sStandardFFpackage, see #38376 (comment). but at the moment the conversion between Sage and Gap FiniteField is wrong.📝 Checklist
⌛ Dependencies