Skip to content

Issue #40806: Support implementation keyword in FiniteField #41203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Issue #40806: Support implementation keyword in FiniteField #41203

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion src/sage/rings/finite_rings/finite_field_constructor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -513,8 +513,14 @@ def __init__(self, *args, **kwds):
def create_key_and_extra_args(self, order, name=None, modulus=None, names=None,
impl=None, proof=None,
check_prime=True, check_irreducible=True,
prefix=None, repr=None, elem_cache=None,
prefix=None, repr=None, elem_cache=None,implementation=None,
**kwds):
# --- START OF FIX ---
if implementation is not None:
if impl is not None:
raise ValueError("Cannot specify both 'impl' and 'implementation'")
impl = implementation
# --- END OF FIX ---
"""
EXAMPLES::

Expand Down Expand Up @@ -606,6 +612,10 @@ def create_key_and_extra_args(self, order, name=None, modulus=None, names=None,
Traceback (most recent call last):
...
ValueError: the order of a finite field must be a prime power
sage: GF(25, impl='givaro', implementation='givaro')
Traceback (most recent call last):
...
ValueError: Cannot specify both 'impl' and 'implementation'

We expect ``name`` to be a string (if it is a single name) and ``names`` to be
a tuple of strings, but for backwards compatibility this is not enforced.
Expand Down