Skip to content

Conversation

@haraldschilly
Copy link
Contributor

@haraldschilly haraldschilly commented Mar 24, 2025

  • SAML: updating node-saml and passport-saml to fix xml-crypto. the update are at least two breaking changes, we need backwards compatibility → this must be tested. Apart from the cert → idpCert conversion, this also changes the default for validateInResponseTo (to the default value "never").
    • I've tested this with my own small SAML server
  • next: 14.2.22 → 14.2.28
    • pages show up fine
  • forced update of tar-fs@2.1.1 → 2.1.2, reverse dependencies like next do not include that update
    • this is just a small dependency update
  • updating @openapitools/openapi-generator-cli … this doesn't directly fix the problem, but at least it is updated to the most recent version and from there is should be just a small step to get the patch
    • I tested it by querying a couple of api endpoints, no problem, API v2 pages show up as usual as well.

deployment: the only real attention must be made to our own SAML SSO

@haraldschilly haraldschilly changed the title npm: update node-saml and passport-saml to fix xml-crypto npm: update packages to fix dependency issues Apr 10, 2025
@haraldschilly haraldschilly marked this pull request as ready for review April 10, 2025 09:44
@williamstein williamstein merged commit 6e7d8fb into master Apr 11, 2025
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants