decoding response content so it can be json loaded in python 3 without simplejson#63
Open
i-yang wants to merge 1 commit intosailthru:masterfrom
Open
decoding response content so it can be json loaded in python 3 without simplejson#63i-yang wants to merge 1 commit intosailthru:masterfrom
i-yang wants to merge 1 commit intosailthru:masterfrom
Conversation
vnatakam
added a commit
that referenced
this pull request
Apr 17, 2026
…hods
- sailthru_response.py: use response.text instead of response.content so
simplejson (which rejects bytes) receives a str; also catch TypeError in
addition to ValueError for robustness
- sailthru_client.py: remove redundant json.loads() in receive_verify_post
since get_body() already returns a parsed dict
- sailthru_client.py: fix get_signature_string() returning bytes instead of
str by moving .encode('utf-8') into get_signature_hash() where hashlib needs it
- test: update receive_verify_post mock to return a dict matching real get_body() behavior
- setup.py: bump version to 2.3.6
Closes INT-1681. Resolves the same issue identified in PR #63 (open since 2017).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Python 3, without simplejson, a successful
api_postcall returns the following exception:TypeError: the JSON object must be str, not 'bytes'. The reason seems to be thatresponse.contentis a bytes literal, which need to be decoded before being passed in tojson.loads.simplejson.loadsseems to handle byte literals, but unfortunately, simplejson conflicts with some of the other third party libraries we're using.