Fix early-access artifact re-download not triggering - #83
Conversation
Two compounding bugs prevented the client from re-downloading updated early-access server/test-runner jars: 1. GitHubRelease lacked @JSON, so avaje-jsonb generated no adapter and fetchReleaseUpdatedAt threw "No JsonAdapter" at runtime. updated_at was never stored, so the freshness check could never evaluate. Make it an @Json-annotated record. 2. Even when flagged stale, downloadAndCache's "already downloaded by another process" guard (verifyCachedChecksum checks only local integrity) returned the old intact jar. Delete the stale jar + .sha256 in getArtifact's stale branch before re-downloading, mirroring the corruption path. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
Warning Review limit reached
More reviews will be available in 14 minutes and 24 seconds. Learn how PR review limits work. Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file). ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
1 participant
Two compounding bugs prevented the client from re-downloading updated early-access server/test-runner jars:
GitHubRelease lacked @JSON, so avaje-jsonb generated no adapter and fetchReleaseUpdatedAt threw "No JsonAdapter" at runtime. updated_at was never stored, so the freshness check could never evaluate. Make it an @Json-annotated record.
Even when flagged stale, downloadAndCache's "already downloaded by another process" guard (verifyCachedChecksum checks only local integrity) returned the old intact jar. Delete the stale jar + .sha256 in getArtifact's stale branch before re-downloading, mirroring the corruption path.