Merge release/3.0.0 into development - #167
Merged
Merged
Conversation
release/3.0.0 changes
salRoid
approved these changes
Jul 26, 2026
There was a problem hiding this comment.
Pull request overview
This PR merges release/3.0.0 into development, primarily tightening network security by moving external endpoints to HTTPS, improving UI/resource consistency by centralizing strings, and making some theming/layout adjustments.
Changes:
- Switched remaining hardcoded external URLs from HTTP to HTTPS and removed
usesCleartextTraffic="true"from the manifest. - Replaced multiple hardcoded UI strings with
strings.xmlresources for maintainability/localization. - Adjusted theming/layout (new text color resource, font/margin tweaks, and a small image size change) and updated Room DB builder behavior.
Reviewed changes
Copilot reviewed 14 out of 15 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| app/src/main/res/values/strings.xml | Moves URLs to HTTPS and introduces new string resources for UI labels/widgets. |
| app/src/main/res/values/colors.xml | Adds a new dark text color resource used by the light theme logic. |
| app/src/main/res/layout/fragment_movies.xml | Updates header styling and replaces section titles with string resources. |
| app/src/main/res/layout/filmy_appwidget.xml | Replaces hardcoded widget text with string resources. |
| app/src/main/res/layout/extra_info_movie_detail.xml | Removes redundant empty android:text="" attributes. |
| app/src/main/res/layout/custom_row.xml | Slightly increases poster image height for list rows. |
| app/src/main/res/layout/all_trailer_layout.xml | Removes redundant empty android:text="" attribute. |
| app/src/main/res/layout/activity_detailed.xml | Replaces hardcoded “+ More” text with a string resource. |
| app/src/main/java/tech/salroid/filmy/ui/home/MoviesFragment.kt | Uses the new text color resource for light theme logo text. |
| app/src/main/java/tech/salroid/filmy/ui/details/MovieDetailsActivity.kt | Switches Metacritic URL to HTTPS. |
| app/src/main/java/tech/salroid/filmy/di/MoviesModule.kt | Changes Room database builder to use destructive migration fallback. |
| app/src/main/java/tech/salroid/filmy/data/network/MoviesApiService.kt | Switches OMDb base URL to HTTPS. |
| app/src/main/AndroidManifest.xml | Removes cleartext traffic allowance from the application manifest. |
| app/build.gradle | Increments versionCode to 23 for the 3.0.0 release line. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements and fixes across the codebase, focusing on enhanced security (by switching to HTTPS for external URLs), improved UI consistency, and better maintainability through the use of string resources. It also includes database migration handling and minor color and layout adjustments.
Security and API Improvements:
MoviesApiService.kt,MovieDetailsActivity.kt,strings.xml). [1] [2] [3] [4]fallbackToDestructiveMigrationto handle schema changes more gracefully (MoviesModule.kt).UI and Theming Updates:
activity_detailed.xml,filmy_appwidget.xml,fragment_movies.xml). [1] [2] [3] [4] [5] [6] [7]MoviesFragment.kt,colors.xml,fragment_movies.xml). [1] [2] [3]Layout and Resource Adjustments:
posterimage height incustom_row.xmland made minor margin and style tweaks in several layouts for improved appearance (custom_row.xml,fragment_movies.xml). [1] [2]android:text=""attributes from several layout files, cleaning up XML (all_trailer_layout.xml,extra_info_movie_detail.xml). [1] [2] [3] [4] [5]Versioning and Manifest Updates:
versionCodeto 23 inbuild.gradleand removedusesCleartextTraffic="true"from the manifest, reflecting the move to HTTPS-only resources (build.gradle,AndroidManifest.xml). [1] [2]