Skip to content

Merge release/3.0.0 into development - #167

Merged
webianks merged 4 commits into
developmentfrom
release/3.0.0
Jul 26, 2026
Merged

Merge release/3.0.0 into development#167
webianks merged 4 commits into
developmentfrom
release/3.0.0

Conversation

@webianks

Copy link
Copy Markdown
Collaborator

This pull request introduces several improvements and fixes across the codebase, focusing on enhanced security (by switching to HTTPS for external URLs), improved UI consistency, and better maintainability through the use of string resources. It also includes database migration handling and minor color and layout adjustments.

Security and API Improvements:

  • Updated all external API and image URLs from HTTP to HTTPS in both the code and string resources for improved security (MoviesApiService.kt, MovieDetailsActivity.kt, strings.xml). [1] [2] [3] [4]
  • Changed the database builder to use fallbackToDestructiveMigration to handle schema changes more gracefully (MoviesModule.kt).

UI and Theming Updates:

  • Replaced hardcoded strings in layouts with string resources for titles and labels, improving localization and maintainability (activity_detailed.xml, filmy_appwidget.xml, fragment_movies.xml). [1] [2] [3] [4] [5] [6] [7]
  • Updated text colors and font usage for better consistency with the app's theme (MoviesFragment.kt, colors.xml, fragment_movies.xml). [1] [2] [3]

Layout and Resource Adjustments:

  • Increased the poster image height in custom_row.xml and made minor margin and style tweaks in several layouts for improved appearance (custom_row.xml, fragment_movies.xml). [1] [2]
  • Removed unnecessary empty android:text="" attributes from several layout files, cleaning up XML (all_trailer_layout.xml, extra_info_movie_detail.xml). [1] [2] [3] [4] [5]

Versioning and Manifest Updates:

  • Incremented versionCode to 23 in build.gradle and removed usesCleartextTraffic="true" from the manifest, reflecting the move to HTTPS-only resources (build.gradle, AndroidManifest.xml). [1] [2]

@webianks
webianks requested a review from salRoid July 26, 2026 14:30
@webianks webianks self-assigned this Jul 26, 2026
@webianks webianks changed the title Implement destructive migration and clean up hardcoded text release/3.0.0 changes Jul 26, 2026
@webianks webianks changed the title release/3.0.0 changes Merge release/3.0.0 into development Jul 26, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR merges release/3.0.0 into development, primarily tightening network security by moving external endpoints to HTTPS, improving UI/resource consistency by centralizing strings, and making some theming/layout adjustments.

Changes:

  • Switched remaining hardcoded external URLs from HTTP to HTTPS and removed usesCleartextTraffic="true" from the manifest.
  • Replaced multiple hardcoded UI strings with strings.xml resources for maintainability/localization.
  • Adjusted theming/layout (new text color resource, font/margin tweaks, and a small image size change) and updated Room DB builder behavior.

Reviewed changes

Copilot reviewed 14 out of 15 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
app/src/main/res/values/strings.xml Moves URLs to HTTPS and introduces new string resources for UI labels/widgets.
app/src/main/res/values/colors.xml Adds a new dark text color resource used by the light theme logic.
app/src/main/res/layout/fragment_movies.xml Updates header styling and replaces section titles with string resources.
app/src/main/res/layout/filmy_appwidget.xml Replaces hardcoded widget text with string resources.
app/src/main/res/layout/extra_info_movie_detail.xml Removes redundant empty android:text="" attributes.
app/src/main/res/layout/custom_row.xml Slightly increases poster image height for list rows.
app/src/main/res/layout/all_trailer_layout.xml Removes redundant empty android:text="" attribute.
app/src/main/res/layout/activity_detailed.xml Replaces hardcoded “+ More” text with a string resource.
app/src/main/java/tech/salroid/filmy/ui/home/MoviesFragment.kt Uses the new text color resource for light theme logo text.
app/src/main/java/tech/salroid/filmy/ui/details/MovieDetailsActivity.kt Switches Metacritic URL to HTTPS.
app/src/main/java/tech/salroid/filmy/di/MoviesModule.kt Changes Room database builder to use destructive migration fallback.
app/src/main/java/tech/salroid/filmy/data/network/MoviesApiService.kt Switches OMDb base URL to HTTPS.
app/src/main/AndroidManifest.xml Removes cleartext traffic allowance from the application manifest.
app/build.gradle Increments versionCode to 23 for the 3.0.0 release line.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread app/src/main/java/tech/salroid/filmy/di/MoviesModule.kt
Comment thread app/src/main/res/values/strings.xml
@webianks
webianks merged commit e6a117f into development Jul 26, 2026
1 check passed
@webianks
webianks deleted the release/3.0.0 branch July 26, 2026 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants