[codex] Fail closed when OIDC HTTP client build fails - #176
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
salasebas
force-pushed
the
codex/fail-closed-oidc-ssrf-client
branch
from
July 1, 2026 06:14
b0c622b to
6dd7021
Compare
salasebas
marked this pull request as ready for review
July 1, 2026 06:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resultinstead of falling back to an unguardedreqwest::ClientRoot Cause
Finding 2 identified a fail-open fallback in the SSO OIDC SSRF guard: if the guarded
OAuthHttpClient::from_configbuild failed, RustAuth wrapped a plainreqwest::Client, losing the DNS resolver and redirect policy used to block private/internal targets.Validation
cargo fmt --all --checkcargo test -p rustauth-sso --all-features oidc_http_clientcargo test -p rustauth-sso --all-features cached_oauth_http_client_failure_is_fail_closedcargo nextest run -p rustauth-sso --all-features(338 passed)cargo clippy --workspace --all-targets --all-features -- -D warnings