[codex] Fix OAuth client reference_id updates - #181
Merged
Conversation
salasebas
force-pushed
the
codex/fix-oauth-reference-id-update
branch
from
July 1, 2026 06:25
290e1d3 to
094b80e
Compare
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
salasebas
marked this pull request as ready for review
July 1, 2026 06:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reject attempts to update an OAuth client's
reference_idthrough the update-client endpoint and stop persisting that field from update payloads.Root Cause
UpdateClientBody.updateaccepted a fullOAuthClient, includingreference_id. The update path merged and persisted that value. Later, theclient_credentialstoken flow copied the stored clientreference_idinto access token storage, allowing an authenticated client owner to spoof the tenant or organization reference used by downstream authorization.Changes
invalid_client_metadatawhen update-client receivesreference_id.reference_idout of the merge and update record paths.Validation
cargo fmt --all --checkcargo clippy --workspace --all-targets --all-features -- -D warningscargo nextest run -p rustauth-oauth-provider --all-featurescargo test -p rustauth-oauth-provider --features test-util update_client_rejects_reference_id_changes_and_preserves_token_reference -- --nocapture