Fix usage of class and containerClass attributes #141
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
By analyzing the blame information on this pull request, we identified @aputinski to be a potential reviewer |
Contributor
|
Thanks! I'll try to get this merged tomorrow. |
Contributor
|
@aputinski I see you haven't merged this yet. Let me know if you need help testing. |
Contributor
|
@shannonsans we're reviewing this internally, thank you for your patience. |
Contributor
|
We reviewed it and it looks good. We just need you to sign our CLA - see CONTRIBUTING.md. |
Contributor
Author
|
CLA sent today. Let me know if you need anything else. |
BrunoFonzi
added a commit
that referenced
this pull request
Feb 29, 2016
Fix usage of class and containerClass attributes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed earlier when using the Lightning SVG Icon Component Helper that the
slds-icon-text-defaultclass wasn't being applied to thesvgelement: it turns out the reason is that theclassattribute was being added to the container (instead of thecontainerClassattribute), and nothing was being added to thesvgelement.This change fixes this issue by getting the
containerClassattribute and setting that on the container, and then adding theclassattribute to thesvg.