-
Notifications
You must be signed in to change notification settings - Fork 433
Combobox: Set role='combobox' on input element #2756
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@bxiao This is bigger than just moving the role attribute. From an open work ticket: W-8074194 The div will just be a wrapper for styles now, it won't have any of the combobox attributes. |
|
Also, as you mentioned on Slack. Please update all variants that have the |
interactivellama
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments
…)" This reverts commit 2b249fc. # Conflicts: # components/combobox/__docs__/__snapshots__/storybook-stories.storyshot # components/combobox/__tests__/combobox.browser-test.jsx # components/combobox/combobox.jsx # components/component-docs.json # components/date-picker/__tests__/__snapshots__/datepicker.dom-snapshot-test.jsx.snap
…)" This reverts commit 2b249fc. # Conflicts: # components/combobox/__docs__/__snapshots__/storybook-stories.storyshot # components/combobox/__tests__/combobox.browser-test.jsx # components/combobox/combobox.jsx # components/component-docs.json # components/date-picker/__tests__/__snapshots__/datepicker.dom-snapshot-test.jsx.snap
* Revert "Combobox: Set role='combobox' on input element (#2756)" This reverts commit 2b249fc. # Conflicts: # components/combobox/__docs__/__snapshots__/storybook-stories.storyshot # components/combobox/__tests__/combobox.browser-test.jsx # components/combobox/combobox.jsx # components/component-docs.json # components/date-picker/__tests__/__snapshots__/datepicker.dom-snapshot-test.jsx.snap * Update snapshots * Remove double roles
Fixes #2753
According to the Aria 1.2 spec for combobox https://www.w3.org/TR/wai-aria-practices-1.2/examples/combobox/combobox-autocomplete-list.html, the
role="combobox"attribute should be set on the innerinputelement, not the containingdiv.Additional description
CONTRIBUTOR checklist (do not remove)
Please complete for every pull request
npm run lint:fixhas been run and linting passes.components/component-docs.jsonCI tests pass (npm test).REVIEWER checklist (do not remove)
components/component-docs.jsontests.Required only if there are markup / UX changes
last-slds-markup-reviewinpackage.jsonand push.last-accessibility-review, topackage.jsonand push.npm run local-updatewithin locally cloned site repo to confirm the site will function correctly at the next release.