Dynamic room type selection #1236
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
October 30, 2019 14:10
ConalCosgrove
requested review from
BrandonMurnane,
LongweiDeng and
cassiodias
cassiodias
approved these changes
Nov 4, 2019
| for (let i = 0; i < urlParamNames.length; i++){ | ||
| const paramName = urlParamNames[i]; | ||
| const urlParamValue = urlParams[paramName]; | ||
| const newRoomType = urlParamValue && _roomTypeMapping[paramName] && |
There was a problem hiding this comment.
is this returning a string or a boolean?
Contributor
Author
There was a problem hiding this comment.
A string - if it exists at the index
| if (!_defaultRoomType) { | ||
| return ''; | ||
| } | ||
| const urlParamNames = Object.keys(urlParams); |
There was a problem hiding this comment.
any reason why not using forEach from here?
Contributor
Author
There was a problem hiding this comment.
you can't break out of a for each, so you'd have to loop through the entire array and then return the found value. This way we can exit the loop as soon as a match is found
LongweiDeng
approved these changes
Nov 4, 2019
BrandonMurnane
approved these changes
Nov 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code change in rooms to allow for more granular roomType selection based on provided url parameters