Aspect tag change realtime events #148
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… (instead of “update”) so that perspectives which filter by aspect tag will get the right sample events.
annyhe
reviewed
Dec 22, 2016
| })) | ||
| .then((s) => { | ||
| expect(s.dataValues.aspect.tags).to.have.members(['T3']); | ||
| done(); |
Contributor
There was a problem hiding this comment.
@iamigo Wouldn't we want the test to assert
expect(aspect.tags).to.deep.equal(['T3'])?
| }); | ||
| }) | ||
| .then(() => resolve(inst)) | ||
| .catch(reject); |
Contributor
There was a problem hiding this comment.
@iamigo do we have a test that asserts on unpublishing an aspect, it loses all of its samples?
annyhe
approved these changes
Dec 22, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an aspect’s tags change, send “delete” and “add” realtime events (instead of “update”)
so that perspectives which filter by aspect tag will get the right sample events.