chore: address post-merge NUT review comments (W-23400737)#677
Open
jhefferman-sfdc wants to merge 1 commit into
Open
chore: address post-merge NUT review comments (W-23400737)#677jhefferman-sfdc wants to merge 1 commit into
jhefferman-sfdc wants to merge 1 commit into
Conversation
Follow-up to #676: - browserUtils: make getAccessToken non-exported (only used within the file) - sessionUtils: use global parseInt for consistency with the rest of the repo (src/configMeta.ts, src/shared/previewUtils.ts, devServerUtils.ts) Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
wjhsf
approved these changes
Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Follow-up to #676 (W-23400737), addressing the two actionable review comments left after that PR merged:
getAccessTokenno longer exported (browserUtils.ts:31) — per @wjhsf, it's only referenced withinbrowserUtils.ts(bygetPreview), so theexportwas unnecessary.Number.parseInt→ globalparseInt(sessionUtils.ts:28) — per @wjhsf, for consistency with the rest of the repo, which uses globalparseInt/parseFloatthroughout (src/configMeta.ts,src/shared/previewUtils.ts, anddevServerUtils.tsin this same helper dir).Both are test-helper-only, no behavior change. Lint + tsc + pre-commit hooks pass locally.
Not addressed (already resolved on #676)
getMaxSupportedApiVersionwas answered inline and the PR was subsequently approved — fail-fast is intentional (an emptyapiVersionMetadatameans the plugin is misconfigured; the shippingdependencyLoader.tsreads the same map and would break too, and there's no canonical default version constant to fall back to).apiVersionMetadata(+ its@lwc/sfdx-local-dev-dist-<v>dist). Adding real support for a newer API version remains a separate product task, by design.@W-23400737@