fix: use most recent alias #124
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peternhale
requested changes
Jun 3, 2021
| const keys = alias.getKeysByValue(username); | ||
| return keys?.length ? keys[0] : undefined; | ||
| // use the most recently added alias for that username | ||
| return keys?.length ? keys[keys.length - 1] : undefined; |
Contributor
There was a problem hiding this comment.
@mshanemc is alias list associated with a user guaranteed to remain in order aliases were created?
Contributor
Author
There was a problem hiding this comment.
- That's how it seems to behave.
- We're not doing any sorting of the object keys in core that I could see
https://github.com/forcedotcom/sfdx-core/blob/107070d43cfc223c7b4fb9bfa6c1ec1c10166b97/src/config/configGroup.ts#L217
maggiben
approved these changes
Jun 9, 2021
maggiben
approved these changes
Jun 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
when there are multiple aliases for the username, use the last (most recent) alias
What issues does this PR fix or reference?
@W-9351642@
forcedotcom/cli#1031