Skip to content

fix: use most recent alias #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maggiben merged 3 commits into from
Jun 15, 2021
Merged

fix: use most recent alias #124

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0ab922a
fix: use most recent alias
mshanemc Jun 2, 2021
5ef83cc
style: accurate name for multiple alias test
mshanemc Jun 3, 2021
904ba3e
Merge branch 'main' into sm/fix-multiple-alias-9351642
mshanemc Jun 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/shared/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,8 @@ import * as open from 'open';
export const getAliasByUsername = async (username: string): Promise<string> => {
const alias = await Aliases.create(Aliases.getDefaultOptions());
const keys = alias.getKeysByValue(username);
return keys?.length ? keys[0] : undefined;
// use the most recently added alias for that username
return keys?.length ? keys[keys.length - 1] : undefined;
Copy link
Contributor

@peternhale peternhale Jun 3, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mshanemc is alias list associated with a user guaranteed to remain in order aliases were created?

Copy link
Contributor Author

@mshanemc mshanemc Jun 3, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. That's how it seems to behave.
  2. We're not doing any sorting of the object keys in core that I could see
    https://github.com/forcedotcom/sfdx-core/blob/107070d43cfc223c7b4fb9bfa6c1ec1c10166b97/src/config/configGroup.ts#L217

};

export const openUrl = async (url: string): Promise<ChildProcess> => {
Expand Down
4 changes: 2 additions & 2 deletions test/shared/utils.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,8 @@ describe('getAliasByUsername', () => {
expect(await getAliasByUsername('username1')).to.equal('alias1');
});

it('returns first alias for a username that has multiple aliases', async () => {
expect(await getAliasByUsername('username2')).to.equal('alias2');
it('returns most recent alias for a username that has multiple aliases', async () => {
expect(await getAliasByUsername('username2')).to.equal('alias2b');
});

it('returns undefined when no matching username is found', async () => {
Expand Down