Skip to content

fix(tests): prevent ChatViewModel cancellation from aborting test host - #156

Merged
YoungSx merged 1 commit into
developfrom
fix/chatviewmodel-cancel-exit-134-issue-139
Sep 2, 2026
Merged

fix(tests): prevent ChatViewModel cancellation from aborting test host#156
YoungSx merged 1 commit into
developfrom
fix/chatviewmodel-cancel-exit-134-issue-139

Conversation

@YoungSx

@YoungSx YoungSx commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Summary

Fixes #139.

  • Treats store-projection cancellation caused by ChatViewModel.Dispose() as a normal terminal condition, while preserving caller-owned cancellation and real faults.
  • Adds a deterministic regression that previously reproduced the AsyncRelayCommand thread-pool rethrow / exit 134 test-host crash.
  • Replaces the two VoiceInput test doubles that raced the background signal poller with an AsyncLocal dispatcher scope and explicit authorization-help synchronization.

Verification

  • dotnet build tests/SalmonEgg.Presentation.Core.Tests/SalmonEgg.Presentation.Core.Tests.csproj -c Debug
  • VoiceInputDiagnosticsProbeViewModelTests: 10 consecutive runs, each 13/13 passed.
  • New Chat cancellation regression: passed.
  • Full SalmonEgg.Presentation.Core.Tests:
    • before rebase: 2 runs, each 3278/3278 passed
    • after rebasing onto current develop: 3286/3286 passed
  • Reverse verification: disabling the lifecycle-cancellation guard restored the original TaskCanceledException, exit 134, and failed: 0 / total: 0 host-abort signature.

The branch was rebased directly onto the latest origin/develop before the final full-suite run, so it is currently fast-forward mergeable unless develop advances again.

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@vercel

vercel Bot commented Sep 1, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
salmonegg Ready Ready Preview Sep 1, 2026 7:04pm UTC

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@YoungSx
YoungSx merged commit 94921c5 into develop Sep 2, 2026
15 checks passed
@YoungSx
YoungSx deleted the fix/chatviewmodel-cancel-exit-134-issue-139 branch September 2, 2026 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant