WIP: add response with request - #6
Closed
Wulfheart wants to merge 3 commits into
Closed
Conversation
Member
|
Maybe we assume the base namespace is in Http/Integrations? If an integration flag is specified, we can assume it is Http/Integrations/Integration1/Responses |
Member
|
Otherwise It could accept a full namespace? Once we figure this out, I just thought it could be cool if you could specify a connector as well as a response. |
Contributor
Author
|
Ok, so what is the way forward now? |
Member
|
Thank you for making this PR, but I think we should revisit this another time. It's definitely useful but I'd like to create a PR in the future that adds a couple of flags to the request: --connector=NameOfConnector (assumes in the Http/Integrations folder) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Would close #3.
However, this is not as trivial as I previously thought.
@Sammyjo20 do you know any way how I could get the full namespace and class name of the newly generated response?