Salt cloud openstack availability zone

[syndicut]

Added support for setting node availability zone in openstack
This feature depends on apache/libcloud#295:
https://issues.apache.org/jira/browse/LIBCLOUD-555

[ghost]

Test Failed.

If the failures are unrelated to your code, don't stress, a core developer will know these apart.
In the future, if possible, please branch off a passing commit to avoid false positives.
Refer to this link for build results: http://jenkins.saltstack.com/job/salt-pr-build/4449/

[techhat]

If this depends on libcloud trunk, it should be documented as such in the code, at the very least.

[gtmanfred]

+1 to this, I would prefer if this was only added to kwargs if it actually is set, and in a possibly in a try: except block so that if they aren't running the newest/trunk version of libcloud, they will actually give a good error at why the server boot isn't working.

Other than that, it looks good

[techhat]

I will have to agree with @gtmanfred on this. @syndicut if you don't mind doing that, I would love to merge this.

[syndicut]

Yep, I'll fix it

[grischa]

Oh, I just wrote this as well, saw this pull request too late.
Here is my version: https://github.com/grischa/salt/compare/openstack_availability_zones?expand=1
It solves the first request, a default of None that doesn't add any kwarg.
It does not do a try..except though, but libcloud will just ignore unknown kwargs, I believe. Once libcloud-trunk with zones has a version number we could test that.

[syndicut]

Oh, can you open pull reqest for your commit? I'll close mine

[grischa]

Done, cheers